Incorrect quoting of double quote in examples_support/server_processing_details_col.php

ssteinerX

Starting on line 76, there is a series of statements that do a str_replace as follows:

[code]
$sOutput .= '"'.str_replace('"', '/"', $aRow['engine']).'",';
[/code]

Shouldn't that be a backslash as in '\"'?

There are no quotes in any of the data rows, so the replace doesn't have to do anything, but if there was a quote there, I don't think this would do what it's supposed to.

S

allan

Hi ssteinerX,

Oops - yes - you are absolutely correct! I've corrected these in my demo scripts now and they will be included in the next release.

Regards,
Allan

ssteinerX

Allan,

Is there a way to keep up with the latest development version?

I don't seem to see a public repository...

Thanks,

S

allan

A public repository for DataTables is something which I have yet to get around to doing... I'm planning to do it as part of the 1.7 development effort. I'll post in the forum when this is available :-)

Regards,
Allan

ssteinerX

Allan,
I'm not sure what your schedule is like, or what you're currently using, but I can tell you from recent experience that moving to a public DVCS repository will increase the amount of help you will get astronomically.

When others can just submit a pull request rather than going through the pain of making patches (especially against a repository to which they have no access), the updates will just start rolling in.

Granted, some of them will not be ones you want to incorporate, but others will and the sense of "co-development" engages other programmers in the best possible way.

I, and I'm sure others, await anxiously. There's a version incorporating these fixes; but I can't get it, can't keep up with other interim bug fixes, and can't contribute. Very frustrating...

Let me know!

Thanks,

S