bugs I have found

bugs I have found

www.wesleywww.wesley Posts: 2Questions: 0Answers: 0
edited August 2009 in Bug reports
(1) In the "complex header example" ( http://www.datatables.net/examples/advanced_init/complex_header.html ), only the first two columns are sortable.

(2) When you combine the "hidden row details" ( http://www.datatables.net/examples/api/row_details.html ) and "shown/hidden columns dynamically" ( http://www.datatables.net/examples/api/show_hide.html ), the "row details" is not shown properly after we toggle visibility of some column.
For testing it:
1. Click to show any row detail
2. Toggle visibility to visible of some column

(3) In the example "shown/hidden columns dynamically" ( http://www.datatables.net/examples/api/show_hide.html ), if you set "bStateSave" to true, manually order by a toggled column and refresh the page, then the table data is not shown.
Ps.: I think this problem only occurs if "bServerSide" is set to true, I mean, the table data is loaded from a remote source, but I didn't test with static data or bServerSide = false
For testing it:
1. Toggle visibility to visible of some column that is invisible by default
2. Sort the table by this toggled column
3. Refresh the page

These are the bugs I can remember for now.

The other bugs I found are too obvious or they were reported already.

Replies

  • allanallan Posts: 63,498Questions: 1Answers: 10,470 Site admin
    Hi www.wesley,

    Nice one - thanks for posting this.

    1. Unfortunately a bug introduced in 1.5.0 - check out this thread for more information and the fix. I'll release 1.5.1 as soon as I can with the fix for this included.

    2. Good shout - I hadn't considered the possibility of combining the column visibility with the fnOpen() and fnClose() functions. The issue is that the 'colspan' is incorrect on the 'open' rows after you've shown or hidden a column. I've put in a fix for this now (also will be in 1.5.1).

    3. I've not been able to reproduce this issue with either the show_hide or the server_side processing (which show/hide options added in). I suppose it's possible that one of the other bug fixes for 1.5.1 has fixed it, but I'm not convinced by that. Perhaps you could post the exact code you are using please?

    Regards,
    Allan
  • www.wesleywww.wesley Posts: 2Questions: 0Answers: 0
    edited August 2009
    Thanks for your very quick reply and please ignore the last one. It was a bug in my sorting algorithm.
    My apologies for my mistake, I'll double check next time before taking your time.

    The next one is more a css issue
    In the example "row grouping" ( http://datatables.net/examples/advanced_init/row_grouping.html ), the bottom keeps static even if we change the numbers of entries per page.
    For testing it:
    1. Show any number of entries greater than 10

    I use Mozilla Firefox 3.0.13 if that helps
  • allanallan Posts: 63,498Questions: 1Answers: 10,470 Site admin
    Hi,

    No problem about the sorting issue - these things happen and your two other bugs were crackers! Good to get them sorted out.

    With the height issue - this is because I've applied a 'giveHeight' classed div to the display which fixes the height at 380px. The intention was to stop the controls on the page bouncing around - unfortunately this was too successful! I should have used min-height - which it does now.

    Regards,
    Allan
  • TheSpyTheSpy Posts: 8Questions: 0Answers: 0
    edited February 2010
    Using four_button pagination at http://www.datatables.net/development/pagination
    classes doesn't change when u click on the "next" or "previous", because of the wrong variables:

    oSettings.iDisplayStart and oSettings.iDisplayEnd

    line 078
    [code]if ( oSettings.iDisplayStart === 0 )[/code]
    should be
    [code]if ( oSettings._iDisplayStart === 0 )[/code]
    and
    line 098
    [code]if ( oSettings.iDisplayEnd == oSettings.aiDisplay.length )[/code]
    should be
    [code]if ( oSettings.fnDisplayEnd() == oSettings.fnRecordsDisplay())[/code]
  • allanallan Posts: 63,498Questions: 1Answers: 10,470 Site admin
    Hi TheSpy,

    Good stuff - thanks for catching that. I've updated the example code now, and also on the pagination plug-ins page.

    Regards,
    Allan
  • TheSpyTheSpy Posts: 8Questions: 0Answers: 0
    Hello Allan,
    Also in the description http://www.datatables.net/development/pagination there is a wrong reference
    "The element pointer 'oSettings.anFeatures.p' is provided by DataTables to contain the paging controls. It is suggested that you add the controls to this element as children. This function takes three arguments:"

    oSettings.anFeatures.p I think should be oSettings.aanFeatures.p

    /Julius Bartkus
  • allanallan Posts: 63,498Questions: 1Answers: 10,470 Site admin
    Hi Julius,

    Agreed! Thanks again :-)

    Are you developing a pagination plug-in? I'd love to have a "3rd party" one to put on the pagination plug-ins page, if you are and would consider allowing it to be freely available :-)

    Regards,
    Allan
  • mciolettimcioletti Posts: 4Questions: 1Answers: 0
    I was able to work around the colspan problem when displaying a detail row by incorporating the detail button column when the parent table is created. I then bind the click event to the existing button image using a callback.

    However, I have noticed another bug. In my situation, I have 2 tabs to switch between 2 different tables, both having row detail to display. When switching between tabs, the display of the detail panel has a tendency to lock-up and not open. There doesn't seem to be any rhyme or reason that triggers this. In fact, I've had times when I switch back to a table previously locked-up, to find it now works correctly. To me, this has the feeling of a memory problem or collision. I was wondering if anyone else has encountered this problem. I"m open to any suggestions on how to fix this problem.
This discussion has been closed.