editor timepicker table appears when deleting a row

carlop

Hi,
I have some trouble with the editor timepicker (see attached images). I can provide the access to the application via private message as it is on intranet.
I am using Bootstrap4 version and the updated version for all packages.

bs4/jszip-2.5.0/dt-1.10.18/e-1.9.0/b-1.5.6/b-html5-1.5.6/fh-3.1.4/r-2.2.2/sl-1.3.0

1. When deleting a row a spurious timepicker table appears on the left side of the confirmation message
2. Despite the use of i18n, the Hour and Minute terms are not translated

i18n: {
            "datetime": {
            "previous": 'Precedente',
            "next":     'Successivo',
            "months":   [ 'Gennaio', 'Febbraio', 'Marzo', 'Aprile', 'Maggio', 'Giugno', 'Luglio', 'Agosto', 'Settembre', 'Ottobre', 'Novembre', 'Dicembre' ],
            "weekdays": [ 'dom', 'lun', 'mar', 'mer', 'gio', 'ven', 'sab' ],
            "amPm":     ['am', 'pm'],
            "unknown":  '-',
            "Hour": "Ora",
            "Minute": "Minuto"
          }
        }

1. The timepicker table does not close on time select so that it covers the Create button. It will be useful that the table closes once the time has been selected.

Many thanks in advance.

colin

Yep, i think we'll need to see this, as it must be code being triggered in your application somewhere. Please can you send your connection details to me, and either Allan or I will take a look,

Colin

allan

Could you update to Editor 1.9.6 please? I recall there was a related bug back around the 1.9.0 time.

Also:

"Hour": "Ora",
"Minute": "Minuto"

should be:

            "hours": "Ora",
            "minutes": "Minuto"

Regards,
Allan

carlop

Hi Allan,
thanks.
The translation of hours and minutes now work.
Concerning the Editor version, it is already 1.9.6

* Included libraries:
 *   JSZip 2.5.0, DataTables 1.10.23, Editor 1.9.6, Buttons 1.6.5, HTML5 export 1.6.5, FixedHeader 3.1.7, Responsive 2.2.7, Select 1.3.1
 */

carlop

Hi Allan,
have you had the opportunity to have a look to the page with the issue we mentioned in the post?
Thanks

allan

Sorry - I've just tried it now but I'm getting an error when logging in with the details you sent Colin and I by PM before:

Utente o password errati, oppure l'utente non e' abilitato. Resetta la password oppure clicca sull'icona ? per ottenere supporto.

Could you possibly send us new details so I can see this issue with the date/time picker showing when the row is deleted please?

Thanks,
Allan

carlop

Hi Allan, I sent the credentials to Collin, thanks.

allan

I've got it now - thanks. I see the issue, but it will require a little code change in Editor. Until then, could you try this workaround - when you call the remove() method, pass in focus: null as part of the options object - e.g.:

              editorRS4.remove( $(this).closest('tr'), {
                title: 'Elimina',
                focus: null,
                ...
              );

Thanks,
Allan

carlop

Hi Allan, thanks for the workaround, it works.
And what about
"The timepicker table does not close on time select so that it covers the Create button. It will be useful that the table closes once the time has been selected." (see attached image).
Is it possible that on select the timepicker closes?
Thanks!

allan

That's actually an intentional design decision in Editor - in the image above, consider what would happen if you want to choose 05:00. A selection on one of them would immediately close the picker - which you'd then want to reopen to pick the other.

We could make it so it will close when both have been selected, but say you wanted to choose 23:00 - that would mean a redundant click and it wouldn't be particularly discoverable.

Another option would be to auto close on minute select, but you might select the minutes first (I know I've done that often enough myself) or the minutes might not need to be changed.

I don't really see a nice way of making it work with an auto close I'm afraid.

Perhaps a wider modal would solve this specific issue for you?

Allan

carlop

Hi Allan, I used a wider modal with the code

editor.on('open', function (e, mode, action) {
  $('.DTED .modal-dialog').addClass("modal-lg");
  $(".DTE_Field .col-form-label").removeClass("col-lg-4").addClass("col-lg-2");
  $(".DTE_Field [data-dte-e=input]").removeClass("col-lg-8").addClass("col-lg-10");
});

and it works well.
Thanks