Server-side Searchpane significantly slower after upgrade to 2.0.8
Server-side Searchpane significantly slower after upgrade to 2.0.8
ruszczak
Posts: 3Questions: 0Answers: 0
Link to test case: https://github.com/DataTables/Editor-PHP/commit/e43d1578529034c3d92a9109e6404fbfad0a2c1a
Debugger code (debug.datatables.net): SQL questions like "SELECT COUNT(*) as cnt FROM table_name WHERE attribute_name=1"
Error messages shown: No error, only longer ajax call (from ~1s up to 40s)
Description of problem: Using mariadb
Hi all,
After upgrading datatables.net/editor-php to 2.0.8 (by composer), my server-side Searchpanes work significantly slower. If no condition for searching is set, it works ok, but with every condition it works about ~5s longer. With profiler I investigated, that code from this commit ("Link to test case") in "_ssp_filter" makes it longer (I commented the code and works faster). Don't see a flag to switch it off (If I understand, this code is not necessary).
Cheers,
Krzysztof
Replies
Hi Krzysztof,
Thanks for flagging this up. I'm not clear which part of the code you've commented out there? Could you clarify that for me and I'll see what we can do about speeding it up.
Thanks,
Allan
Hi Allan,
Thanks for reply. From commit mentioned above, by Editor.php lines 1928:1958 .
Cheers,
Krzysztof
That's nasty - thanks for spotting that. I agree, that implementation is not right. I'll dig into this in detail for the next patch release.
Allan
Hi Allan,
Correct me if I'm wrong, but this issue was not fixed in latest release? (2.0.9)
Cheers,
Krzysztof