CSS for datatables.net-select-bs4 v1.4.0 does not match what's in github repo

Ritualjitsu

Description of problem:

Links in selected rows are invisible because the background and link colors are identical.

Cause:

Both the CDN and NPM package for datatables.net-select-bs4 is missing the last 9 lines shown in the Github repo. These lines make the color of links in a selected row visible.

CDN link: https://cdn.datatables.net/select/1.4.0/css/select.bootstrap4.css

Github source: https://github.com/DataTables/Dist-DataTables-Select-Bootstrap4/blob/1.4.0/css/select.bootstrap4.css

The Github version includes these lines (129-138) at the end:

table.dataTable tbody tr.selected,
table.dataTable tbody th.selected,
table.dataTable tbody td.selected {
  color: white;
}
table.dataTable tbody tr.selected a,
table.dataTable tbody th.selected a,
table.dataTable tbody td.selected a {
  color: #a2d4ed;
}

But both the CDN and NPM distributions don't include these lines.

allan

Thanks for noting this. With the changes in DataTables 1.12 this code should actually be in the DataTables stylesheet rather than Select now (the github link is slightly out of sync there - it will come back in soon).

What I've done to address this is to make this commit to DataTables and it will be in the nightly shortly.

I'm not sure about the colour I've used, but the light blue from before wasn't right either - it was providing a really low contrast against the background.

Allan